Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed loading of styles #47

Closed
justinelsberry opened this issue Sep 27, 2016 · 3 comments
Closed

Delayed loading of styles #47

justinelsberry opened this issue Sep 27, 2016 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@justinelsberry
Copy link

justinelsberry commented Sep 27, 2016

When visiting a microsite, often the styles take a long time to load so you see the page without style for a second or so before the styled version loads.

For me, this can be seen on both these sites:
https://47deg.github.io/scalacheck-datetime/
https://47deg.github.io/fetch/

2016-09-27 16_19_02

@justinelsberry justinelsberry added the bug Something isn't working label Sep 27, 2016
@justinelsberry
Copy link
Author

I see that those 2 sites mentioned may not have used the sbt-microsites plugin as the styles are loaded differently than on https://47deg.github.io/sbt-microsites/. The style is loaded in javascript so its deferred until after the page is loaded. @juanpedromoreno should we create tickets to upgrade those projects to use this version?

@rafaparadela
Copy link
Contributor

Yes. Fetch, Mvessel and Github4s are using the previous version of
Microsite.

I would suggest that Alex, Fede and myself to spend some minutes to move it
into the new version based on the plugin.

I'd also recommend removing the repo "microsites" since is not longer
available.
On Wed, 28 Sep 2016 at 01:35, Justin Elsberry notifications@github.com
wrote:

I see that those 2 sites mentioned may not have used the sbt-microsites
plugin as the styles are loaded differently than on
https://47deg.github.io/sbt-microsites/. The style is loaded in
javascript so its deferred until after the page is loaded.
@juanpedromoreno https://github.com/juanpedromoreno should we create
tickets to upgrade those projects to use this version?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATOvtIvFITHyg_7Pme9MW5nMnnIG8toks5quagvgaJpZM4KIQlQ
.

@juanpedromoreno
Copy link
Member

Closing this issue since all the mentioned projects here (using the old microsites project) are now using the sbt-microsites plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants