Add abilitiy to configure different git hosting services. #124
Conversation
| @@ -54,5 +54,9 @@ trait MicrositeKeys { | |||
| val micrositePalette = settingKey[Map[String, String]]("Microsite palette") | |||
| val micrositeGithubOwner = settingKey[String]("Microsite Github owner") | |||
| val micrositeGithubRepo = settingKey[String]("Microsite Github repo") | |||
| val micrositeGitHostingService = | |||
| settingKey[String]("Service used for git hosting. By default, it'll be 'Github'.") | |||
| val micrositeGitHostingUrl = settingKey[String]( | |||
There was a problem hiding this comment.
can we set this automatically to empty strings when the user specifies a different micrositeGitHostingService automatically so they don't have to do that themselves?
|
@raulraja Updated with your recommendations. Also added some JS that will hide the github related watching/stars stats if it's not a GitHub project. |
|
Is Travis is failing because it's a chicken and egg situation or is it legit? This is my first dive into an SBT plugin. It passed locally after a |
|
Looks like the scripted tests are failing. They need to be adjusted to reflect the new settings. We also need to make sure this change does not break existing configurations for other sites. Is any of the new keys or settings mandatory or change the way the setup works? Also instead of having the stats and stuff from github.com hidden perhaps we should not make the call to github.com unless that is the provider applied to a given configuration. Potentially we could add a new setting key to not fetch github.com stats and contributions which would be useful regardless for people not wanting to show those. |
|
Right. I'm just not sure if the test I added is only failing because it's trying to fetch These new settings should be optional and have no effect if they're not used. I will update to undo hiding the GitHub stat indicators. |
|
@raulraja Any guidance on how you want me to proceed with the test? |
|
@juanpedromoreno is there anything special that needs to happen for the scripted test to work in this scenario? |
There was a problem hiding this comment.
Cool, it worked. This new feature looks good to me, great contribution!
@raulraja Seems like we need your blessing here before merging. Thanks!
|
@cranst0n thanks for your contribution! |
|
@raulraja @juanpedromoreno Thanks for working to get this in. Happy to make a small contribution to a really great project! |
First run at #123. Note that I also upgraded FontAwesome to 4.7.0 only because it added a GitLab icon in 4.6.0.