-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kazari improved functionality and integration with sbt-microsites #128
Kazari improved functionality and integration with sbt-microsites #128
Conversation
…t-microsites/tut code layout structure
… gist button from modal until gist functionality is ready - add reset button to restore modal snippets to original state
…mpiled and included in the generated microsites
…r - updated original CSS files
…nced snippets, with working modal window showing independent source codes - Reset button behavior
…t-microsite's own resource folder
micrositeGithubRepo := "sbt-microsites", | ||
micrositeKazariStyle := "kazari-style-dark", | ||
micrositeKazariEvaluatorUrl := "https://scala-evaluator-212.herokuapp.com", | ||
micrositeKazariEvaluatorToken := "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to leave the scala-evaluator as default, how can people get the evaluator token?
CC @raulraja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to generate a new token. The tokens are not to prevent people from accessing it but to identify where they come from and somewhat have an idea of usage. Ultimately we made the decision to gear towards letting client side apps contact the evaluator directly instead of proxying through servers so those tokens will be visible in the client side anyway. Scala Exercise is on of those cases, eventually all exercises will call the evaluator directly instead of through the Scala exercises server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…xercises evaluator
@juanpedromoreno @raulraja as suggested, I've created a token for Kazari to use in the Scala Exercises evaluator and added it as a default for that setting in sbt-microsites. |
Fixes: #125
This PR adds code to make Kazari work with
sbt-microsites
generated code snippets. It's a rather long one, and it can be viewed as a three separate tasks process:sbt-microsites
snippets. Its code is also cleaner and better separated into UI/functionality components.sbt-microsites
site generation. This includes adding new sbt settings to configure the plugin and adding styles and the Kazari script (as well as dependency/resolver list metas) into the auto-generated layouts.sbt_microsites
, so they're available when the plugin is built after a pull request to master.sbt_microsites
so they're already available in the repository.Note: this alone doesn't make Kazari ready for launch in production yet, work to do that will be done in issue #129.
Could you please review, @juanpedromoreno? Thanks, and sorry again for such a lengthy PR.