Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kazari improved functionality and integration with sbt-microsites #128

Merged
merged 18 commits into from
Feb 3, 2017

Conversation

jdesiloniz
Copy link

@jdesiloniz jdesiloniz commented Feb 2, 2017

Fixes: #125

This PR adds code to make Kazari work with sbt-microsites generated code snippets. It's a rather long one, and it can be viewed as a three separate tasks process:

  • Improving functionalities of the existing Kazari code to make it work with sbt-microsites snippets. Its code is also cleaner and better separated into UI/functionality components.
  • Integrating Kazari into the sbt-microsites site generation. This includes adding new sbt settings to configure the plugin and adding styles and the Kazari script (as well as dependency/resolver list metas) into the auto-generated layouts.
  • Adding scripts to automatically build and copy the script and resources needed for Kazari to work into the resources folder of sbt_microsites, so they're available when the plugin is built after a pull request to master.
  • Adding needed CSS and JS resources to the sbt_microsites so they're already available in the repository.

Note: this alone doesn't make Kazari ready for launch in production yet, work to do that will be done in issue #129.

Could you please review, @juanpedromoreno? Thanks, and sorry again for such a lengthy PR.

@jdesiloniz jdesiloniz self-assigned this Feb 2, 2017
micrositeGithubRepo := "sbt-microsites",
micrositeKazariStyle := "kazari-style-dark",
micrositeKazariEvaluatorUrl := "https://scala-evaluator-212.herokuapp.com",
micrositeKazariEvaluatorToken := "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to leave the scala-evaluator as default, how can people get the evaluator token?

CC @raulraja

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to generate a new token. The tokens are not to prevent people from accessing it but to identify where they come from and somewhat have an idea of usage. Ultimately we made the decision to gear towards letting client side apps contact the evaluator directly instead of proxying through servers so those tokens will be visible in the client side anyway. Scala Exercise is on of those cases, eventually all exercises will call the evaluator directly instead of through the Scala exercises server.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a question around the token, though this is absolutely great, LGTM!
giphy 3

@jdesiloniz
Copy link
Author

@juanpedromoreno @raulraja as suggested, I've created a token for Kazari to use in the Scala Exercises evaluator and added it as a default for that setting in sbt-microsites.

@jdesiloniz jdesiloniz merged commit acd899a into kazari-integration Feb 3, 2017
@jdesiloniz jdesiloniz deleted the kazari-tags-behaviour-implementation branch February 3, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants