Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP - Creates new makeMicrosite task #13

Merged
merged 5 commits into from Sep 12, 2016

Conversation

juanpedromoreno
Copy link
Member

Additionally, fixes a problem with the _config.yml file, which wasn't copied to the target/site directory.

Please, @rafaparadela could you review it?

Thanks!

* Scalafmt as code formatter
* sbt-header for license header purposes
* Improves scala object dependencies
* Applies some cleaning and improves de code directory structure
@rafaparadela
Copy link
Contributor

LGTM. As suggestion I would create another task publishMicrosite which concatenates makeMicrosite and ghpagesPushSite (from sbt-ghpages) that requires:

git.remoteRepo := "git@github.com:{your username}/{your project}.git"

For that we need include ghpages.settings.

On the other hand, adding clean at the beginning of the task makes sense?

@juanpedromoreno
Copy link
Member Author

juanpedromoreno commented Sep 12, 2016

Makes sense. And yes, we can do it in a separate PR, where we can integrate the gh pages sbt plugin. Thanks.

#16

@juanpedromoreno juanpedromoreno merged commit 75b9ea7 into master Sep 12, 2016
@juanpedromoreno juanpedromoreno deleted the jp-fixes-config-yml-site-adds-multi-task branch September 12, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants