Remove logo inline styles #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesiloniz
approved these changes
Feb 6, 2017
There was a problem hiding this comment.
@vlovgr Thanks Viktor! Good catch, and your fix makes sense to us! There are some changes merged to master today that are conflicting yours, could you please update your branch with the latest commtis from master them so we can merge your work? :)
added 2 commits
February 7, 2017 08:05
The inline style is not required as it's already in the external stylesheet. It also prevents the logo from rendering in 2x.
The inline style is not required as it's already in the external stylesheet. It also prevents the logo from rendering in 2x.
|
@jdesiloniz Done! :) |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inline styles preventing logo on docs and page layouts from being rendered at 2x.
To see this in action, uncheck the
backgroundinline style for the logo on these pages:and see how they now render using the 2x version on a high DPI (retina) screen.