Support for favicon #133
Merged
Support for favicon #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdesiloniz We should autogenerate the favicon since that is more valuable than even providing new settings. Can we address that separate from #114? Based on community members feedback that is more satisfying since you don't need to create one at all. If done from jekyll we can use some ruby gem to postprocess the images or in sbt if we use something like https://github.com/sksamuel/scrimage downscale the images as an sbt task that generates the favicon if none is present in the setting. |
|
@raulraja Sure. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #114
This PR adds code to let users customize a favicon in their microsites. It also divides the current MicrositeSettings case class in several case classes as we already reached the point of having more than 22 fields.
Could you please review, @juanpedromoreno? Thanks!