Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including default includeFilter in sbt-microsites settings #135

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

jdesiloniz
Copy link

Fixes: #134

This PR fixes a bug that prevented non-PNG image resources to be used in microsites. sbt-site uses a filter setting to copy those files, but until now it wasn't being used correctly. The right configuration will be now applied by default, and will include the most common image file extensions.

Could you please review, @juanpedromoreno? Thanks!

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Good catch!

@jdesiloniz jdesiloniz merged commit e6a388a into master Feb 6, 2017
@jdesiloniz jdesiloniz deleted the sm134-non-png-images-are-not-copied branch February 6, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some non-PNG image files are not copied to the final generated site
2 participants