Autogenerate favicons from the navbar_brand file as a default option #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent standard sizes, and link them to the layouts as a default option
| 196, | ||
| 310).map { w => | ||
| (w, w) | ||
| } ++ Seq((310, 150)) |
There was a problem hiding this comment.
I'd suggest doing this in this way:
@ val list = List(16,24,32,48,57,60,64,70,72,76,96,114,120,128,144,150,152,196,310,150)
list: List[Int] = List(16, 24, 32, 48, 57, 60, 64, 70, 72, 76, 96, 114, 120, 128, 144, 150, 152, 196, 310, 150)
@ list zip list
res1: List[(Int, Int)] = List((16, 16), (24, 24), (32, 32), (48, 48), (57, 57), (60, 60), (64, 64), (70, 70), (72, 72), (76, 76), (96, 96), (114, 114), (120, 120), (128, 128), (144, 144), (150, 150), (152, 152), (196, 196), (310, 310), (150, 150))Also, do you really want a favicon size of (310, 150)?
There was a problem hiding this comment.
Thanks for the suggestion! That size is for Windows 8/IE11 tiled favicons apparently.
juanpedromoreno
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #136
This PR adds a default option for the favicon setting in the
sbt-microsites, that creates a set of favicons from thenavbar_brand2x.jpgfile (offering different sizes for different devices) and links them to our different layouts.Could you please review, @juanpedromoreno? Thanks!!