Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kazari design improvements #139

Merged
merged 4 commits into from
Feb 16, 2017

Conversation

jdesiloniz
Copy link

Fixes: #129, #130

This PR adds code to fix several design issues with the Kazari code decorator. Mainly:

  • Implemented the design changes added by @israelperezglez to fix layout and CSS issues.
  • Kazari no longer has two themes to choose from. Setting for that option removed, now using single CSS stylesheet.
  • Retrieving color schemes from the applied highlight.js theme to match the color of the Kazari button bar as better as possible.
  • Also matching background color from highlight.js theme to the CodeMirror modal view.
  • Adding an SBT setting to configure the CodeMirror theme.
  • Switched default theme to solarized-dark.
  • Switched default color highlight in CodeMirror to CLike/Scala for better compatibility.

Could you please review, @juanpedromoreno?? Thanks!!

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

giphy 8

@jdesiloniz jdesiloniz merged commit 11b672f into kazari-integration Feb 16, 2017
@jdesiloniz jdesiloniz deleted the sm129-kazari-design-improvements branch February 16, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants