Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates sbt-org-policies Plugin #147

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

juanpedromoreno
Copy link
Member

  • Upgrades sbt version
  • Upgrades sbt-ghpages plugin version
  • Moves the artifact to com.47deg groupId

Please, @fedefernandez could you review? Thanks!

* Upgrades sbt version
* Upgrades sbt-ghpages plugin version
* Moves the artifact to groupId com.47deg
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

crossScalaVersions := Seq("2.11.8"),
skip in packageJSDependencies := false,
libraryDependencies ++= Seq(
"org.scala-js" %%% "scalajs-dom" % "0.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use here the sbt-org-policies deps?

"com.lihaoyi" %%% "scalatags" % "0.6.0",
"org.querki" %%% "jquery-facade" % "1.0-RC6",
"org.denigma" %%% "codemirror-facade" % "5.11-0.7",
"com.fortysevendeg" %%% "github4s" % "0.9.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the last version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I'll use the sbt-org-policies later on. First I need this in master. Thanks.

@juanpedromoreno juanpedromoreno merged commit 9b505f8 into master Mar 22, 2017
@juanpedromoreno juanpedromoreno deleted the sbt-org-policies-integration branch March 22, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants