Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed gitter channel #183

Merged
merged 3 commits into from
May 16, 2017
Merged

Conversation

AntonioMateoGomez
Copy link
Contributor

Fixed: #32

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, once addressed, LGTM!

@@ -24,6 +24,8 @@ import sbt._
import sbt.plugins.IvyPlugin
import tut.Plugin._

import scalatags.generic.{Attr, Namespace}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these imports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove them

@juanpedromoreno juanpedromoreno merged commit c96023a into master May 16, 2017
@juanpedromoreno juanpedromoreno deleted the paolo-#32-embed-gitter-channel branch May 16, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants