Fixes metatags and solarized-dark issues #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 18, 2017 17:44
create docs for some setting
juanpedromoreno
requested changes
May 19, 2017
docs/src/main/tut/docs/settings.md
Outdated
|
|
||
| ``` | ||
| micrositeOrganizationHomepage := "http://www.47deg.com" | ||
| ``` | ||
|
|
||
| - `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). |
There was a problem hiding this comment.
-This generate a meta that Twitter use in his
+This generates a meta that Twitter uses in its
docs/src/main/tut/docs/settings.md
Outdated
| micrositeTwitter := @sbt-microsites | ||
| ``` | ||
|
|
||
| - `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). |
| val micrositeOrganizationHomepage: SettingKey[String] = | ||
| settingKey[String]("Microsite organisation homepage") | ||
| val micrositeTwitter: SettingKey[String] = settingKey[String]("Microsite twitter") | ||
| val micrositeTwitterCreator: SettingKey[String] = settingKey[String]("Microsite twitter") |
There was a problem hiding this comment.
"Microsite Twitter Creator"
| val micrositeHomepage: SettingKey[String] = settingKey[String]("Microsite homepage") | ||
| val micrositeOrganizationHomepage: SettingKey[String] = | ||
| settingKey[String]("Microsite organisation homepage") | ||
| val micrositeTwitter: SettingKey[String] = settingKey[String]("Microsite twitter") |
| @@ -97,6 +97,6 @@ class HomeLayout(config: MicrositeSettings) extends Layout(config) { | |||
| ) | |||
|
|
|||
| def scriptsKazari: List[TypedTag[String]] = | |||
| scripts ++ List(script(src := "{{ site.baseurl }}/js/kazari.js"), script(kazariEnableScript)) | |||
| scripts ++ List(script(src := "{{ site.baseurl }}/js/kazari.js"), kazariEnableScript) | |||
| ) ++ ganalytics.toList | ||
| href := "{{site.url}}{{site.baseurl}}/img/favicon.png"), | ||
| meta(name := "twitter:title", content := config.identity.name), | ||
| meta(name := "twitter:image", content := s"${config.identity.homepage}img/poster.png"), |
There was a problem hiding this comment.
We should check here we have the slash at the end (there is a helper to check it)
juanpedromoreno
requested changes
May 19, 2017
docs/src/main/tut/docs/settings.md
Outdated
| @@ -68,13 +68,13 @@ micrositeHomepage := "https://47deg.github.io/sbt-microsites/" | |||
| micrositeOrganizationHomepage := "http://www.47deg.com" | |||
| ``` | |||
|
|
|||
| - `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). | |||
| - `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in its [Twitter Cards](https://cards-dev.twitter.com/validator). | |||
There was a problem hiding this comment.
Still This generate instead of This generates
AND
Twitter use instead of Twitter uses
docs/src/main/tut/docs/settings.md
Outdated
|
|
||
| ``` | ||
| micrositeTwitter := @sbt-microsites | ||
| ``` | ||
|
|
||
| - `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
| - `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in its [Twitter Cards](https://cards-dev.twitter.com/validator). |
| @@ -134,6 +134,11 @@ trait MicrositeAutoImportSettings extends MicrositeKeys { | |||
| s"/${micrositeBaseUrl.value}" | |||
| else micrositeBaseUrl.value | |||
|
|
|||
| val homepage = | |||
There was a problem hiding this comment.
This is not needed, as I mentioned before, there is a helper method to cover it.
See this example
added 2 commits
May 19, 2017 12:22
juanpedromoreno
requested changes
May 19, 2017
docs/src/main/tut/docs/settings.md
Outdated
| - `micrositeTwitter`: this setting is used for the Twitter integration. This generates a meta that Twitter uses in its [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
|
|
||
| ``` | ||
| micrositeTwitter := @sbt-microsites |
There was a problem hiding this comment.
Just realized micrositeTwitter is expecting a string => "@sbt-microsites"
docs/src/main/tut/docs/settings.md
Outdated
| - `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generates a meta that Twitter uses in its [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
|
|
||
| ``` | ||
| micrositeTwitterCreator := @47deg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add meta tag and doc for Twitter creator
Fix Twitter image meta tag for Twitter card
Add Twitter and homepage settings docs
Fixes #156 and #179