Gitter Link Settings #197
Merged
Gitter Link Settings #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 18, 2017 17:44
create docs for some setting
…atags # Conflicts: # src/main/scala/microsites/MicrositeKeys.scala
raulraja
approved these changes
Jun 11, 2017
There was a problem hiding this comment.
Awesome, @juanpedromoreno can you also take a look at this? Thanks!
juanpedromoreno
requested changes
Jun 11, 2017
| @@ -98,6 +98,7 @@ object MicrositesPlugin extends AutoPlugin { | |||
| micrositePushSiteWith := GHPagesPlugin, | |||
| micrositeAnalyticsToken := "", | |||
| micrositeGitterChannel := true, | |||
| micrositeGitterChannelUrl := "", | |||
There was a problem hiding this comment.
You could set the default value here, based on owner/repo.
| |room: '${config.gitSettings.githubOwner}/${config.gitSettings.githubRepo}'};""".stripMargin), | ||
| script(src := s"https://sidecar.gitter.im/dist/sidecar.v1.js") | ||
| ) | ||
| val gitSidecar: List[TypedTag[String]] = |
There was a problem hiding this comment.
Addressing the comment above, we wouldn't need to add any special logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195 Create a setting to custom Gitter channel