Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GA script parsing mode for smoother navigation jumps #243

Merged
merged 2 commits into from
Nov 30, 2017

Conversation

calvellido
Copy link
Contributor

  • Upgrade sbt-org-policies version dependencies to 0.8.17.

  • Set async attribute for the GA script code, to not make the rest of
    the HTML parsing get stopped by it.

  • Position to load and parse the Google Analytics code after the rest of
    the needed dependencies, specially after the CSS styling files, thus
    making the render smoother between navigation jumps.

This fixes #75

* Set async attribute for the GA script code, to not make the rest of
the HTML parsing get stopped by it.
* Position to load and parse the Google Analytics code after the rest of
the needed dependencies, specially after the CSS styling files, thus
making the render smoother between navigation jumps.
Copy link
Contributor

@dominv dominv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvellido calvellido merged commit cddebf1 into master Nov 30, 2017
@calvellido calvellido deleted the jv-75-change-ga-script-parsing branch December 1, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ugly menu transition of the docs website
2 participants