Add anchor links handlers #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add three JS function to main.js, which given a DOM content block, traverse its header elements, and given that they include an id attribute, an anchor link element will be added. * As the project already uses Font Awesome, this link shows the fa-link icon. * Add the necssary CSS code to get this added element hidden by default, and show it on hover.
calvellido
requested review from
raulraja,
dominv,
juanpedromoreno and
jdesiloniz
jdesiloniz
reviewed
Dec 1, 2017
| @@ -12,6 +13,34 @@ function activeToggle() { | |||
| }); | |||
| } | |||
|
|
|||
| var anchorForId = function (id) { | |||
There was a problem hiding this comment.
It could be great if we could move these functions to Scala.js code, as it's a short script! Maybe for a future PR?
juanpedromoreno
requested changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #74.