Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows hide Github and Social links in docs layout #257

Merged

Conversation

skaldarnar
Copy link
Contributor

  • adds setting key micrositeShareOnSocial whether to show/hide the
    share on social buttons in docs layout
  • adds setting key micrositeGithubLinks whether to show/hide GitHub
    links for stars and forks in docs layout

Please let me know whether you are fine with this addition or if I'm missing something. Also, naming and correct locations for the settings are up for discussion…

- adds setting key `micrositeShareOnSocial` whether to show/hide the
share on social buttons in docs layout
- adds setting key `micrositeGithubLinks` whether to show/hide GitHub
links for stars and forks in docs layout
@calvellido calvellido self-requested a review February 7, 2018 09:50
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you very much @skaldarnar, these are really good additions to the features list of the project.

A couple things before merging. Would you be so kind to add these new feature to the documentation also? Probably the best location for them will be here:

https://github.com/skaldarnar/sbt-microsites/blob/feature/customize-docs-layout/docs/src/main/tut/docs/settings.md

Also, as the way tests are set in the project, could you also add these new settings to the arbitraries?

https://github.com/skaldarnar/sbt-microsites/blob/feature/customize-docs-layout/src/test/scala/microsites/util/Arbitraries.scala

Thanks!

@skaldarnar
Copy link
Contributor Author

Thanks for your feedback.

I hope this fully addresses your change requests. If anythin is left, please let me know.

@calvellido
Copy link
Contributor

Awesome @skaldarnar, thank you very much. Will merge and release a new version including the two new features 🎉!

@calvellido calvellido merged commit 1fde117 into 47degrees:master Feb 8, 2018
@skaldarnar skaldarnar deleted the feature/customize-docs-layout branch February 8, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants