Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {% raw %} directive to embedded {{page.path}} #326

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

sritchie
Copy link
Contributor

@sritchie sritchie commented Sep 2, 2019

Without this change, the {{page.path}} blocks actually resolve on the published microsite (from https://47deg.github.io/sbt-microsites/docs/settings.html):

image

With the change it doesn't. Here's an example of what the results look like on my generated test site:

image

Without this change, the `{{page.path}}` blocks actually resolve on the published microsite.
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your time @sritchie !

@sritchie
Copy link
Contributor Author

sritchie commented Sep 2, 2019

Of course @juanpedromoreno!

You know, there was one more thing I noticed that I wanted to ask about before submitting a PR. In the docs, you reference getEnvVar in a few places. It took me a while to realize that before using this command in build.sbt I needed to add

import sbtorgpolicies.utils.getEnvVar

to the top of my build file... BUT I noticed that that was NOT required in this buildfile for Mu:

https://github.com/higherkindness/mu/blob/master/build.sbt#L3

It looks like that project might belong on your README as a user, by the way! https://github.com/higherkindness/mu

@juanpedromoreno
Copy link
Member

juanpedromoreno commented Sep 3, 2019

@sritchie Oh, that's right, that function comes from https://github.com/47deg/sbt-org-policies sbt plugin, which is used by sbt-microsites.

In the case of mu the import is not needed because is also explicitly using sbt-org-policies, 👉 https://github.com/higherkindness/mu/blob/master/project/plugins.sbt#L4 .

@juanpedromoreno juanpedromoreno merged commit 938f406 into 47degrees:master Sep 3, 2019
@calvellido
Copy link
Contributor

Nice catch @sritchie! 👍

@sritchie sritchie deleted the patch-3 branch September 5, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants