sbt-native-packager is not being used for now #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the useful code from that plugin. In addition, it adds the license file associated to it.
|
Makes sense. LGTM |
rafaparadela
approved these changes
Sep 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as we are not using
sbt-native-packager, we are removing it from the plugin configuration, just to avoid transitive conflict in the libraries using the sbt-microsites plugin.In contrast, we are using a piece of code that is useful within our scope, hence we extracted it from that project, and, the LICENSE has been included as the license of this project.
Please, @raulraja could you take a look? Thanks!