Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "New style redesign"" #361

Merged

Conversation

AntonioMateoGomez
Copy link
Contributor

Reopen "New style redesign" PR in order to fix travis build

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AntonioMateoGomez, @calvellido ! 👏

@juanpedromoreno
Copy link
Member

@AntonioMateoGomez Is this ready to go? 🚀

@calvellido
Copy link
Contributor

Yes it is, we didn't merged in case you wanted to have a version release before 1.0.0 (based on this #355 (comment))

@juanpedromoreno
Copy link
Member

Thanks @calvellido for pointing it out. I've just commented on that PR, presently we have other breaking changes that I think we want to deliver altogether in 1.0.0. Does it make sense?

@calvellido
Copy link
Contributor

Definitely @juanpedromoreno, looking forward to the release of sbt-microsites 1.0.0!

@calvellido calvellido merged commit 8279fb0 into master Nov 8, 2019
@calvellido calvellido deleted the revert-359-revert-354-paolo-334-new-style-redesign branch November 8, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants