Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site home change #368

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Site home change #368

merged 2 commits into from
Nov 13, 2019

Conversation

AntonioMateoGomez
Copy link
Contributor

This PR changes the site home layout to homeFeatures

calvellido
calvellido requested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we keep the previous info? Or is this layout not supporting that? 🤔

@AntonioMateoGomez
Copy link
Contributor Author

AntonioMateoGomez commented Nov 13, 2019 •
edited

This layout doesn´t support that, it would looks like this:

Captura de pantalla 2019-11-13 a las 9 54 32

@calvellido
Copy link
Contributor

calvellido commented Nov 13, 2019 •
edited

Uhmmm, then, I'd think on moving the info previously present there onto a new page, as it's valid info. Ideally that new one could be the default one under docs path afterwards.

@AntonioMateoGomez
Copy link
Contributor Author

Ok, we move the previous home info into a new page intro in the docs layout

calvellido
calvellido approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍

@AntonioMateoGomez AntonioMateoGomez merged commit acd52c9 into master Nov 13, 2019
@calvellido calvellido deleted the paolo-change-site-home branch November 13, 2019 10:40
@calvellido calvellido mentioned this pull request Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvellido calvellido calvellido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntonioMateoGomez @calvellido