Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP - Adds Additional Documentation #37

Merged
merged 17 commits into from
Sep 23, 2016

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Sep 22, 2016

This PR brings several new features like:

  • Improved documentation, new sections.
  • New Images resources
  • Layout improvements
  • Bring back the top menu icons
  • New Liquid metatag to be able to order the different doc sections.

You can see the result here:

https://47deg.github.io/sbt-microsites/

Note: the content and lang review will be done as a part of this other issue: #33

Fixes #33, thanks to the @MaureenElsberry's review.

Please, @raulraja @rafaparadela could you review? Thanks!

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the README should include the basic process for installation and link to the rest of the docs for details.

@juanpedromoreno
Copy link
Member Author

@raulraja Basic process for installation and link have been added to the README.file. Could you take another look? Thanks!

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpedromoreno juanpedromoreno merged commit 8b6ae3a into master Sep 23, 2016
@juanpedromoreno juanpedromoreno deleted the jp-adds-more-documentation branch September 23, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants