Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Sass/SCSS support #373

Merged
merged 10 commits into from
Nov 20, 2019
Merged

Custom Sass/SCSS support #373

merged 10 commits into from
Nov 20, 2019

Conversation

calvellido
Copy link
Contributor

@calvellido calvellido commented Nov 20, 2019 •
edited

  • Add micrositeSassDirectory setting.
  • Add specific tasks to copy and process the SCSS and their partial files.
  • Add specific sass custom load path to Jekyll config.
  • Remove config file copy, which breaks things when serving built sites.
  • Add Sass/SCSS feature support documentation.

This closes #372

juanpedromoreno
juanpedromoreno reviewed Nov 20, 2019
View reviewed changes
src/main/scala/microsites/MicrositeKeys.scala
@@ -289,15 +299,10 @@ trait MicrositeAutoImportSettings extends MicrositeKeys {
_root_.tut.TutPlugin.tutOne(streams.value, r, in, out, cp, opts, pOpts, re).map(_._1)
},
makeTut := {
Def.sequential(microsite, tut, micrositeTutExtraMdFiles, makeSite, micrositeConfig)
Def.sequential(microsite, tut, micrositeTutExtraMdFiles, makeSite)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the micrositeConfig task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that it could be removed from the list of available tasks, or if this change of removing it from the sequence of this task is ok?

If it's the former one, I'd say that yes, just checked it and it's not being used anymore.

If it's the second one, also yes, that task was adding a config.yml to the already Jekyll processed site.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I meant first :)

If we are not using it anymore we could remove it 👍 Thanks

AntonioMateoGomez
AntonioMateoGomez approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@AntonioMateoGomez AntonioMateoGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic @calvellido !

@calvellido calvellido merged commit 0c9ede9 into master Nov 20, 2019
@calvellido calvellido deleted the jv-372-sass-support branch November 20, 2019 10:56
@calvellido calvellido mentioned this pull request Nov 20, 2019
Closed
@calvellido calvellido mentioned this pull request Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@AntonioMateoGomez AntonioMateoGomez AntonioMateoGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Sass/SCSS support
3 participants
@calvellido @juanpedromoreno @AntonioMateoGomez