Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design implementation #64

Merged
merged 9 commits into from
Oct 21, 2016
Merged

Design implementation #64

merged 9 commits into from
Oct 21, 2016

Conversation

jdesiloniz
Copy link

This PR includes the following:

  • Implementation of the design for the decorator and modal window.
  • Refactoring of the DOM methods and complete separation of DOM-manipulation and code-decoration classes.
  • Inclusion of Kazari's two CSS themes in the resources folder (at least until we make a final release in a CDN somewhere).
  • Updated and fixed Kazari's documentation.

Could you please review, @juanpedromoreno? Thanks!!

juanpedromoreno
juanpedromoreno approved these changes Oct 20, 2016
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should consider to include unit tests for the UI, this is starting to be quite big, besides awesome ;)

@jdesiloniz jdesiloniz merged commit a37f993 into 0.3.0-version Oct 21, 2016
@jdesiloniz jdesiloniz deleted the javi-implement-design branch October 21, 2016 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdesiloniz @juanpedromoreno