Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external layouts and partial layouts #95

Merged
merged 4 commits into from
Nov 11, 2016

Conversation

jdesiloniz
Copy link

This PR includes code to allow users of the plugin to include their own layouts and partial layouts to their sbt-microsites-generated sites.

Could you please review, @juanpedromoreno @raulraja? Thanks!

@@ -38,13 +38,18 @@ class MicrositeHelper(config: MicrositeSettings) {
copyPluginResources(pluginURL, s"$targetDir$jekyllDir/", "css")
copyPluginResources(pluginURL, s"$targetDir$jekyllDir/", "img")
copyPluginResources(pluginURL, s"$targetDir$jekyllDir/", "js")
copyPluginResources(pluginURL, s"$targetDir$jekyllDir/", "layout")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plugin providing any custom html layout? If it isn't, this line is not needed

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment added. Apart from that, this is great.
LGTM!

@jdesiloniz jdesiloniz merged commit b59f80a into master Nov 11, 2016
@jdesiloniz jdesiloniz deleted the javi-add-external-layouts branch November 11, 2016 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants