-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for plugin create (Sourcery refactored) #796
Conversation
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Preview page for your plugin is ready here: |
a21438d
to
2311d5b
Compare
def __new__(mcs, name, bases, attrs, **kwargs): | ||
def __new__(cls, name, bases, attrs, **kwargs): | ||
methods = kwargs.pop("methods", []) | ||
suggested_base_class = kwargs.pop("suggested_base_class", None) | ||
class_methods = kwargs.pop("class_methods", []) | ||
cls2 = super().__new__(mcs, name, bases, attrs, **kwargs) | ||
cls2 = super().__new__(cls, name, bases, attrs, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AddRegisterMeta.__new__
refactored with the following changes:
- The first argument to class methods should be
cls
(class-method-first-arg-name
)
Codecov ReportBase: 89.83% // Head: 89.83% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## docs/plugin_create #796 +/- ##
===================================================
Coverage 89.83% 89.83%
===================================================
Files 195 195
Lines 30036 30036
===================================================
Hits 26984 26984
Misses 3052 3052
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Pull Request #795 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
docs/plugin_create
branch, then run:Help us improve this pull request!