Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ruff rules (Sourcery refactored) #911

Merged

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Mar 14, 2023

Pull Request #910 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the upgrade_ruff_configuration branch, then run:

git fetch origin sourcery/upgrade_ruff_configuration
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from Czaki March 14, 2023 17:51
packages = pkgutil.iter_modules(__path__, __name__ + ".")
packages = pkgutil.iter_modules(__path__, f"{__name__}.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_plugins refactored with the following changes:

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Mar 14, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 3.47 ⭐ 3.47 ⭐ 0.00
Method Length 28.00 ⭐ 28.20 ⭐ 0.20 👎
Working memory 5.60 ⭐ 5.60 ⭐ 0.00
Quality 84.41% 84.36% -0.05% 👎
Other metrics Before After Change
Lines 24 24 0
Changed files Quality Before Quality After Quality Change
package/PartSegCore/plugins/__init__.py 84.41% ⭐ 84.36% ⭐ -0.05% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit d83a29a into upgrade_ruff_configuration Mar 14, 2023
8 of 14 checks passed
@Czaki Czaki deleted the sourcery/upgrade_ruff_configuration branch March 14, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant