Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CallType #4 @laravelian #7

Merged
merged 3 commits into from
May 6, 2020
Merged

Fix CallType #4 @laravelian #7

merged 3 commits into from
May 6, 2020

Conversation

Saifallak
Copy link
Contributor

@Saifallak Saifallak commented Sep 8, 2019 •
edited
Loading

Fix CallType as mentioned per #4 @laravelian

i needed this fix so here is PR

fixes #7,

satellitebots
satellitebots reviewed Jan 26, 2020
View reviewed changes
Copy link

@satellitebots satellitebots left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me. Please consider merging. The cached_number often times returns null. This has been a huge issue for development and testing.

@niravt07 niravt07 mentioned this pull request Feb 3, 2020
Closed
@synw synw mentioned this pull request Apr 25, 2020
Closed
@fpicoitoj
Copy link
Contributor

Stumbled upon this a long time ago, still waiting for the PR, so I've made a fork with the fix:
https://github.com/Cenas-Factory/call_log

@ethael
Copy link
Member

ethael commented May 1, 2020

thanks a lot. we will check it out during next week.

MartinHlavna
MartinHlavna reviewed May 6, 2020
View reviewed changes
Copy link
Member

@MartinHlavna MartinHlavna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinHlavna MartinHlavna merged commit d1727f1 into 4Q-s-r-o:master May 6, 2020
@MartinHlavna MartinHlavna mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHlavna MartinHlavna MartinHlavna left review comments

@satellitebots satellitebots satellitebots left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Saifallak @fpicoitoj @ethael @MartinHlavna @satellitebots