Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
DS-4166 Index workspace, workflow and tasks in SOLR #65
This PR is to share the implementation of the indexing features required for the implementation of the MyDSpace.
Integration Tests have been added to the DiscoverControllerIT to demonstrate:
PR to highlight the small changes required to the Discover (search) endpoint DSpace/Rest7Contract#55
Regarding the multi-threaded indexing, does it makes sense to do that as a distinct JIRA/PR pair? It doesn't seem essential to the functionality being introduced here, and would seem worth dedicated consideration.
I agree that moving toward something like spring executors would probably result in more robust thread management. I also think some dedicated testing would be good...at least to show/report that there's a throughput improvement for a typical site for the chosen default number of threads.
referenced this pull request
Mar 28, 2019
Hi all, thanks to all of you @benbosman @KevinVdV @cwilper @tdonohue for your review. I tried to put response with links in all the comment to speedup the validation process.
done, see b98d8f4
done, see 689ac4e
I have preferred to avoid any changes on that. If we will end in replace the search.resoucetype field with a search.resourcename field we can drop the new constants at this time instead than introduce a double way to deal with this things now.
If a change to the current implementation of the Constants class is needed it can be done in my opinion after the preview release or later.