Include taglib (http://java.sun.com/jsp/jstl/core) in main.jsp. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'dspace.layout.head.last' properly. This will no longer corrupt main.jsp when rendered due to lengthy content in <c:set>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational
Taglib (http://java.sun.com/jsp/jstl/core) is not included in
main.jspbut used to setdspace.layout.head.last.This caused
dspace.layout.head.lastto never be set properly.This is the source code the browser receives from the server.
<c:set>was not processed by the servlet.Fortunately, no problems emerged because the JavaScript within
<c:set var="dspace.layout.head.last" scrope="request">...</c:set>could be interpreted without problems by the browser.But recent changes for our instance, which expanded this JavaScript code, rendered the site unusable, since the servlet consistently chopped off parts of the JavaScript when it became too long before proceeding with the rest of the page.
This PR fixes this issue by importing the respective taglib which was forgotten in eaac488.