Draft: Implementation of an organization unit tree frontend #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4Science/DSpace#383
References
Add references/links to any related issues or PRs. These may include:
issue-number
4
Description
Shows node inside some tree and additional metrics as some standalone explore section element.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
The display of the icons and metrics badges can be configured in the configuration in the new introduced TreeRenderingConfig
The config is usable for multiple trees, so the tree can be named in
treeRendering.entries.treename
. For every entity in the tree (mostly OrgUnit) some specific item can be configured intreeRendering.entries.entityicons
.For every node metrics configured in the
orgunittree.xml
file the icon can be configured intreeRendering.entries.renderings
with the shortname of the metrics as the key. The optional valuetreeRendering.entries.renderings.hidezero
can be used to hide metric badged which have the value zero. Some additionaltreeRendering.entries.renderings.tooltip
can be specified to show some tooltip hovering above the metric badges.Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.