Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rest_api submodule #100

Merged
merged 20 commits into from May 23, 2023
Merged

Deprecate rest_api submodule #100

merged 20 commits into from May 23, 2023

Conversation

ace-e4s
Copy link
Member

@ace-e4s ace-e4s commented May 22, 2023 •
edited by vegard-solum-4ss

This PR is related to user story DST-499

Description

Provide a short description about the work that has been done.

Checklist

  • PR title is descriptive and fit for injection into release notes (see tips below)
  • Correct label(s) are used

PR title tips:

  • Use imperative mood
  • Describe the motivation for change, issue that has been solved or what has been improved - not how
  • Examples:
    • Add functionality for Allan variance to sensor_4s.simulate
    • Upgrade to support Python 9.10
    • Remove MacOS from CI

@ace-e4s ace-e4s added the refactor Changes to the code label May 22, 2023
vegard-solum-4ss
vegard-solum-4ss approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@vegard-solum-4ss vegard-solum-4ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vegard-solum-4ss vegard-solum-4ss merged commit 3713851 into master May 23, 2023
9 checks passed
@vegard-solum-4ss vegard-solum-4ss deleted the dst-499-dep-restapi branch May 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegard-solum-4ss vegard-solum-4ss vegard-solum-4ss approved these changes

Assignees
No one assigned
Labels
refactor Changes to the code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ace-e4s @vegard-solum-4ss