update version urllib3 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have not set an upper version limit, should I do that as well? |
|
I don't think we should lock to upper. That is a difficult concept, because in theory we only know we work with 2, but in practice this causes issues when someone wants to use version 3 in their project and we need to update the package to allow that. Semantic versioning is painful, I think the lesser of two evils are just disallowing what we know is broken. |
bjorn-einar-bjartnes-4ss
approved these changes
Nov 3, 2023
hanne-opseth-rygg-4ss
deleted the
ESS-2036-the-new-retry-policy-in-drio-python-has-a-version-dependency-of-some-packages-which-is-not-included-in-requirements-txt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-2036
Checklist