Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support New Netdata Swap Chart Name #338

Merged
merged 2 commits into from Jan 22, 2024

Conversation

Deleh
Copy link
Contributor

@Deleh Deleh commented Jan 12, 2024

The swap chart was renamed from system.swap to mem.swap. Both tables are queried now in the same manner as the CPU core temperatures are, ref

@Deleh Deleh force-pushed the fix/netdata_swap_chart branch 2 times, most recently from 1368e7e to 8f0f89a Compare January 12, 2024 18:01
Copy link

@schmid-jn schmid-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Still some issues with NetData Diagnostic. Detected on mrl-7.

@fmessmer
Copy link
Contributor

fmessmer commented Jan 18, 2024

would it make sense to also add a new KeyValue to the diagnostics which gives us the netdata version installed on the system?
most netdata diagnostic issues where related to a new/different netdata version...

@Deleh
Copy link
Contributor Author

Deleh commented Jan 18, 2024

would it make sense to also add a new KeyValue to the diagnostics which gives us the netdata version installed on the system? most netdata diagnostic issues where related to a new/different netdata version...

Yes, good idea 👍

@Deleh
Copy link
Contributor Author

Deleh commented Jan 18, 2024

image

Still some issues with NetData Diagnostic. Detected on mrl-7.

This happens only on mrl-7 which has indeed a different (and newer) netdata version than mrl-8. I'll have a look how to fix this, those cpu.cpu* tables seem to have gone completely.

@Deleh
Copy link
Contributor Author

Deleh commented Jan 18, 2024

This seems to be an issue with netdata itself which can't gather the relevant data. The relevant CPU data isn't even shown in the web interface.

How it is
image

How it should be
image

Let's try a reboot first.

@Deleh
Copy link
Contributor Author

Deleh commented Jan 18, 2024

would it make sense to also add a new KeyValue to the diagnostics which gives us the netdata version installed on the system? most netdata diagnostic issues where related to a new/different netdata version...

I've added the netdata version as key-value pair to CPU Info for now.

@benmaidel
Copy link
Contributor

Are the changes backwards compatible with old netdata versions? If not we should not forget to update netdata on all robots (basf, afi)

@Deleh
Copy link
Contributor Author

Deleh commented Jan 18, 2024

Are the changes backwards compatible with old netdata versions? If not we should not forget to update netdata on all robots (basf, afi)

The swap changes are backwards-compatible. The version was not included until now but is available on e.g. mrl-2.

Copy link
Contributor

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deleh while you are on it
could you have a look at the old PR #330
if it contains something useful maybe integrate it into #338
if not, please close #330

@Deleh
Copy link
Contributor Author

Deleh commented Jan 19, 2024

@Deleh while you are on it could you have a look at the old PR #330 if it contains something useful maybe integrate it into #338 if not, please close #330

#330 was a workaround for the mrk statemachine when we had serious problems with netdata. Malformed data should be treated as error, not as warning. I'll close it but keep the branch if we run into problems again.

@schmid-jn
Copy link

Tested also on mrl-8:
image
Looks god

Copy link

@schmid-jn schmid-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fmessmer fmessmer merged commit aa1fde3 into 4am-robotics:indigo_dev Jan 22, 2024
1 check passed
@Deleh Deleh deleted the fix/netdata_swap_chart branch January 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants