Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving tag-based callback dependencies breaks when declared with .js file extension #73

Closed
jeffschwartz opened this issue Jul 3, 2019 · 1 comment
Closed

Resolving tag-based callback dependencies breaks when declared with .js file extension #73

jeffschwartz opened this issue Jul 3, 2019 · 1 comment
Assignees
@jeffschwartz
Labels
bug Something isn't working generator related Issue is generator related incremental build related Issue is incremental build related
Milestone
v1.0.0-rc.3

Comments

@jeffschwartz
Copy link
Contributor

In module lib/buildanalyzer/resolveDependencies/resolvers/getCallbackDeps.js determining chains of dependencies for callbacks declared with file extensions (data-trio-callback="someFile.js") fails.
@jeffschwartz
Copy link
Contributor Author

jeffschwartz commented Jul 3, 2019 •
edited
Loading

The fix for this is to map all paths that are returned from calls to getTagCallbackDependencies to just their file names without file extensions using path.parse(path).name.

@jeffschwartz jeffschwartz added this to the v1.0.0-rc.3 milestone Jul 3, 2019
@jeffschwartz jeffschwartz added bug Something isn't working generator related Issue is generator related incremental build related Issue is incremental build related labels Jul 3, 2019
@jeffschwartz jeffschwartz self-assigned this Jul 3, 2019
jeffschwartz added a commit that referenced this issue Jul 3, 2019
@jeffschwartz
addresses issue #73, which would cause dependency
8e5c153 
resolution to fail if callbacks are declared with
their ".js" file extensiions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschwartz jeffschwartz

Labels
bug Something isn't working generator related Issue is generator related incremental build related Issue is incremental build related
Projects
None yet
Milestone
v1.0.0-rc.3
Development

No branches or pull requests
1 participant
@jeffschwartz