Strip gmail's html quote properly #49
Conversation
Gmail web interface uses not-totally-standard quotes: div (or blockquote) with class=gmail_quote, instead of blockquote with type=cite. Without this fix, NestedQuote Remover can't clean anything in gmail correspondence. Without "generic div hander" cite depth is computed incorrectly, so don't remove it (it works for depth=1 but not for others).
| if (depth > maxDepth) { | ||
| node.remove(); | ||
| } else { | ||
| processHtmlBlockquotes(node.childNodes, replyHeaderHandling, maxDepth, depth + 1); | ||
| } | ||
| } | ||
|
|
||
| else if (node.nodeType === Node.ELEMENT_NODE && | ||
| node.nodeName === "DIV" && |
There was a problem hiding this comment.
Is it possible that the "gmail variant" has a "BLOCKQUOTE" or "DIV" as the node name???
If gmail only uses DIV... then why do we need the altered if condition above?
There was a problem hiding this comment.
Yes, it is possible when you already have a long conversation with multiple quotations from different clients (gmail web/regular different email clients).
This patch actually adds gmail web quote handling and fixes support of other clients' quotes.
There was a problem hiding this comment.
I've simplified the whole section and pushed it to the dev-branch.
Please let me know if this still works for you.
Thank you.
There was a problem hiding this comment.
The new version doesn't work for this exact email with maximum quote depth allowed > 1.
Try it yourself.
There was a problem hiding this comment.
@ValdikSS I'm sorry... but I hope you understand that I'm going to let this issue rest for a while.
I really tried to reproduce the issue... but couldn't.
Your modifications to the code would introduce complexity and also may lead to unwanted side-effects (since at some point you treat simple DIVs as quotes, etc.).
Hope you understand that I'm a bit hesitant here.
There was a problem hiding this comment.
I really tried to reproduce the issue... but couldn't.
That's because you're using "reply" button while in a plain text view. It does add color bars, just like on your screenshot (no non-colored bars). In this mode the extension works correctly. However, it doesn't while replying in HTML mode.
There was a problem hiding this comment.
I've emailed you the video. Please watch it.
Oh. Okay... just watched it.
That was helpful. 😄
I'll get back to it. (Probably next weekend.)
Thanks!
There was a problem hiding this comment.
Hello, any updates?
There was a problem hiding this comment.
No... sorry.
I've opened another issue to work on this.
Haven't found the time for it so far. 😞
| processHtmlBlockquotes(node.childNodes, replyHeaderHandling, maxDepth, depth); | ||
| } | ||
|
|
||
| else if (node.nodeType === Node.ELEMENT_NODE && |
There was a problem hiding this comment.
Hmmm... yet another variant.
Can you provide the HTML-source of a Gmail quote for me? So I can have a look at it?
Thank you very much!
There was a problem hiding this comment.
Your email server rejects .eml files.
Re- обход блокировки.zip
Password is in email.
| } | ||
|
|
||
| else if (node.nodeType === Node.ELEMENT_NODE && | ||
| node.nodeName === "DIV") // generic div |
There was a problem hiding this comment.
@ValdikSS : I'm not sure that this last else-if is a bit too generic.
Basically this would mean, that ANY node that is a DIV will get treated as a blockquote.
Which is not good.
I tend to remove this last else block, but keep the other ones.
There was a problem hiding this comment.
Check my email example, it won't work correctly without this code. If you can make it better, go ahead.
Gmail web interface uses not-totally-standard quotes: div (or blockquote) with class=gmail_quote, instead of blockquote with type=cite.
Without this fix, NestedQuote Remover can't clean anything in gmail correspondence. Without "generic div hander" cite depth is computed incorrectly, so don't remove it (it works for depth=1 but not for others).