Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Custom Providers #4

Closed
Ganbin opened this issue Oct 11, 2022 · 4 comments
Closed

Feature Request - Custom Providers #4

Ganbin opened this issue Oct 11, 2022 · 4 comments

Comments

@Ganbin
Copy link

Ganbin commented Oct 11, 2022

User Story

As a developer, I want to be able to use the 4D Net Kit component to request third party that implement OAuth2 with some specific implementation that are not fully covered by the spec.

Examples

Authorize URL of third party app: {{OAuthBaseUrl}}/authorize?client_id=<Client_ID>&response_type=code&redirect_uri=<Redirect_URL>&customParam={{customValue}}

Another example is : {{OAuthBaseUrl}}/{{tenantUUID}}/token

Features that could help to solve this case

  1. Allow to easily add our class inside the component that inherit from a base class. This base class could implement interface functions that allow to have a callback when getting the authorize or token URL. By default the function return the classic URL but our specific class can implement a specific callback to add some custom parameters or replace some placeholder in the URL.

  2. Having a collection that allow to add parameters and their values.

  3. The tenant in the URL seems to be covered by the Microsoft solution, but I'm not sure if this can be used for other providers.

@yannicktrinh
Copy link
Contributor

I think the latest implementations in the component meet your needs (you now should be able to use any oauth2 provider).
Can you confirm that this is the case, and if so, close the issue?
Thanks for the feedback

@Ganbin
Copy link
Author

Ganbin commented Jun 9, 2023

Hi, I have tested the latest code in this Github repo and I could connect to an external OAuth2 provider. However it was not the case in the default component in the v20. I hope this latest code will soon be merged in the v20. (or maybe the latest nightly build already have it)

The only case that I could not test (and didn't look at the code if this is possible) is the use case with the customParam={{customValue}} when doing the authorize or token request.

@Ganbin
Copy link
Author

Ganbin commented Jun 9, 2023

Postman has recently added this feature nicely:

2023-06-09_17-23-02

@yannicktrinh
Copy link
Contributor

I'm closing this "old" issue.
If you encounter any other problem or lack of functionality, please open a new issue.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants