Novalid fix #114
Merged
Novalid fix #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…periment options (--type HiC, --type Chip-Seq, --type Repliseq, --type FISH)
…date with processed files produced from. Added FileFormat to the known types Added a check for if a user is admin and restrict types of sheets that are generated for non-admin user if --all argument is used.
sbreiff
reviewed
Aug 21, 2018
wranglertools/get_field_info.py
Outdated
| excluded_types = ['ExperimentMic_Path', 'OntologyTerm'] | ||
| if not connection.admin: | ||
| excluded_types.extend([ | ||
| 'User', 'Lab', 'Award', 'Organism', 'FileFormat', 'FileReference', |
There was a problem hiding this comment.
I'm not sure we really want FileReference to be in excluded_types if the user isn't admin - this is used for things like fastq barcodes now or fish probe sequences so may often be needed for experiment metadata submission.
Updating branch from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.