Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T MERGE UNTIL FOURFRONT file_format_part_2 is Merged - Ext file fix #116

Merged
merged 10 commits into from Sep 26, 2018

Conversation

aschroed
Copy link
Member

@aschroed aschroed commented Sep 5, 2018

These changes to Submit4DN are necessary for dealing with file_format being an item.
This branch should not be merged until fourfront file_format_part_2 has been merged and preferably deployed on data.

@coveralls
Copy link

coveralls commented Sep 5, 2018

Coverage Status

Coverage increased (+0.08%) to 86.945% when pulling 5acdea4 on ext_file_fix into 116ba06 on master.

Copy link
Member

@KorayKirli KorayKirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed some comments and merged master. I don't think I covered all use cases but expected cases work fine.

@aschroed aschroed merged commit 06e3278 into master Sep 26, 2018
@aschroed aschroed deleted the ext_file_fix branch September 26, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants