Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fffe fix #121

Merged
merged 3 commits into from Oct 30, 2018
Merged

Fffe fix #121

merged 3 commits into from Oct 30, 2018

Conversation

sbreiff
Copy link
Contributor

@sbreiff sbreiff commented Oct 30, 2018

  • removed reference to file_format_file_extension in submit4dn test fixtures
  • fixed regex in import_data.validate_item - had a problem where validation for an OntologyTerm field with the item '/ontology-terms/EFO%3A0006274/' was getting converted to '/OntologyTerm/ontology-terms/EFO%3A0006274/' and failing - new regex recognizes hyphens in item type

@sbreiff sbreiff requested a review from aschroed October 30, 2018 17:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.945% when pulling 90ee7fe on fffe_fix into f7a808d on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.945% when pulling 90ee7fe on fffe_fix into f7a808d on master.

@aschroed aschroed merged commit d82071c into master Oct 30, 2018
@aschroed aschroed deleted the fffe_fix branch October 30, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschroed aschroed Awaiting requested review from aschroed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbreiff @coveralls @aschroed