Windows path handling #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See slack thread in the 4DN_infrastructure channel for how and why these changes were made. |
andreacosolo
changed the title
There was a problem hiding this comment.
Tested on a Windows machine and filename path is handled properly. I also added two tests for posix and windows paths, which seem to pass. Finally, I fixed another bug related to path handling of keyfile on windows, now working again.
Still, file upload fails on windows due to an awscli error. I made a fresh virtual environment with python 3.8.10 and run pip install submit4dn.
(s4dn_test) PS C:\Users\Andrea\GitHub\Submit4DN> aws --version
File association not found for extension .py
Traceback (most recent call last):
File "C:\Users\Andrea\GitHub\Submit4DN\s4dn_test\Scripts\aws.cmd", line 50, in <module>
import awscli.clidriver
ModuleNotFoundError: No module named 'awscli'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change handling of paths and the actual aws call taken from SubmitCGAP