-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Check Schedule #222
Tweak Check Schedule #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notwithstanding my small questions, this looks fine.
@@ -756,7 +756,7 @@ | |||
"title": "Process Download Tracking Items", | |||
"group": "System checks", | |||
"schedule": { | |||
"hourly_checks": { | |||
"ten_min_checks": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is just trying to keep up with the pace? Too bad there's not a comment field in this format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. If we want to keep this we need it running very regularly as we can only purge ~100 or so every run. If we do it every hour we will only delete ~2400 and on Cloudwatch I see tens of thousands being generated overnight. This change will allow us to at least purge ~15000 or so a day, which should help us keep up.
@@ -110,7 +110,7 @@ | |||
"title": "Change in item counts", | |||
"group": "Metadata checks", | |||
"schedule": { | |||
"morning_checks": { | |||
"morning_checks_2": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this rename? Is this just a name or something semantic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
morning_checks_2
is actually a separate, unused schedule that is staggered from the regular morning_checks
. You can see the schedule in app.py
.
purge_download_tracking_items
to no longer bail when staging deploy is runningchange_in_item_counts
to run on the secondary morning check schedule