Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Check Schedule #222

Merged
merged 5 commits into from
Jan 16, 2020
Merged

Tweak Check Schedule #222

merged 5 commits into from
Jan 16, 2020

Conversation

willronchetti
Copy link
Member

  • Changes purge_download_tracking_items to no longer bail when staging deploy is running
  • Changes the above check to run every 10 mins
  • Changes change_in_item_counts to run on the secondary morning check schedule

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.313% when pulling 5c1e202 on purge_fix into 42e0849 on master.

Copy link
Collaborator

@netsettler netsettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notwithstanding my small questions, this looks fine.

@@ -756,7 +756,7 @@
"title": "Process Download Tracking Items",
"group": "System checks",
"schedule": {
"hourly_checks": {
"ten_min_checks": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just trying to keep up with the pace? Too bad there's not a comment field in this format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. If we want to keep this we need it running very regularly as we can only purge ~100 or so every run. If we do it every hour we will only delete ~2400 and on Cloudwatch I see tens of thousands being generated overnight. This change will allow us to at least purge ~15000 or so a day, which should help us keep up.

@@ -110,7 +110,7 @@
"title": "Change in item counts",
"group": "Metadata checks",
"schedule": {
"morning_checks": {
"morning_checks_2": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this rename? Is this just a name or something semantic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

morning_checks_2 is actually a separate, unused schedule that is staggered from the regular morning_checks. You can see the schedule in app.py.

@willronchetti willronchetti merged commit c26421f into master Jan 16, 2020
@willronchetti willronchetti deleted the purge_fix branch January 16, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants