Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ontology check fix #260

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Ontology check fix #260

merged 3 commits into from
Apr 3, 2020

Conversation

sbreiff
Copy link
Contributor

@sbreiff sbreiff commented Apr 3, 2020

Ontology Changes

  • changed ontology check to grab top 2000 bytes of owl file, instead of looking for version in repos - this will help ensure that the version we're looking it is the version that's been uploaded to whatever site is hosting it.
  • if no date or release info is present in versionIRI, now looks at oboInOwl:date field (fix for SO)

Other Changes

  • assay_subclass_dict in assay classification check now includes 'transcription - single cell' and 'open chromatin - single cell' so that sci-ATAC-seq and sci-RNA-seq aren't flagged

@sbreiff sbreiff requested a review from aschroed April 3, 2020 16:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.995% when pulling a46eae0 on ont_fix into d55a9c9 on master.

@sbreiff sbreiff merged commit 3a68ee6 into master Apr 3, 2020
@KorayKirli KorayKirli deleted the ont_fix branch April 16, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschroed aschroed aschroed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbreiff @coveralls @aschroed