Create CGAP production env auto-deploy #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be deployed on the same schedule as fourfront staging.
| def deploy_ff_staging(connection, **kwargs): | ||
| """ Deploys Fourfront master to whoever staging is. | ||
| Runs as part of the 'deployment_checks' schedule on data ONLY. | ||
| def deploy_env(connection, env_to_deploy, name, check, **kwargs): |
There was a problem hiding this comment.
Having the @check_function decorator here will break things as it is not a check function itself but a helper function to run the below two checks. You cannot "nest" checks this way, see the decorator code.
| """ Deploys Fourfront master to whoever staging is. | ||
| Runs as part of the 'deployment_checks' schedule on data ONLY. | ||
| def deploy_env(connection, env_to_deploy, name, check, **kwargs): | ||
| """ For a given beanstalk environment, deploys, or returns an error. |
There was a problem hiding this comment.
I would at least say what name is in the docstring as it not clear that by name you mean application_name.
added 4 commits
June 25, 2020 10:25
- clearer docstring (ended up clearing up name as well) - correct use of check_function decorator
netsettler
approved these changes
Jun 25, 2020
| if helper_check.status == 'PASS': | ||
| this_check.status = 'PASS' | ||
| this_check.summary = 'Successfully deployed Fourfront master to %s' % env_to_deploy | ||
| this_check.summary = 'Successfully deployed {0} master to {1}'.format(application_name, env_to_deploy) |
There was a problem hiding this comment.
Minor: I have a very small preference, once you have multiple args, for named arguments to format, which is easier to keep track of visually than numbers, as in (untested):
this_check.summary = ('Successfully deployed {what} master to {where}'
.format(what=application_name, where=env_to_deploy))
| env_to_deploy=compute_cgap_prd_env(), | ||
| application_name="CGAP Portal", | ||
| check='deploy_cgap_production', | ||
| **kwargs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be deployed on the same schedule as fourfront staging.