Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'publish' target in the Makefile #7

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

netsettler
Copy link
Collaborator

This sets up so that make publish will publish to PyPi, assuming that:

  • $PYPI_USER and $PYPI_PASSWORD are set.
  • There are no changes on the branch.
  • The branch is tagged.
  • The user answers "Y" or "Yes" (in any case) to an 'are you sure' query.

This script should be possible to centralize at some point. And we might want to rewrite it in Python so that it can just be imported from a utils package, or something like that. But this should suffice for now and can be cut&pasted into other poetry-based repos easily enough as a stopgap.

…doesn't check that the tag matches what we will publish. This should be good enough for now, though.)
Copy link
Member

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you could also add something to .travis.yml so that tagged branches automatically push an update to PyPi. IRC I did this for Submit4DN

@netsettler
Copy link
Collaborator Author

Looks good, you could also add something to .travis.yml so that tagged branches automatically push an update to PyPi. IRC I did this for Submit4DN

Yeah, I thought about that. For this small repo, I didn't want to take the time to debug the credentials part of that this time. I'll circle back to it another day. Having the command will make it easy enough.

@netsettler netsettler merged commit 059f6c3 into master Mar 16, 2020
@netsettler netsettler deleted the kmp_add_make_target_publish branch March 30, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants