This repository has been archived by the owner on May 11, 2021. It is now read-only.
Global logback config #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private File globalPropertiesFile() { | ||
| def env = System.getenv() | ||
| String configFolder = env['CONFIG_FOLDER'] | ||
| return new File("${configFolder}/common/global.properties") |
There was a problem hiding this comment.
Yes, it will. You asked a similar question in the past and I have already explained it to you :)
There was a problem hiding this comment.
I don't remember. Maybe it wasn't me or maybe I have too many threads to handle I just threw away your explanations from my mind ;). Anyway great that you checked it.
|
I'm thinking about moving LogbackConfig class to micro-infra-spring. WDYTAI? |
|
There are no direct dependencies to Logback, so it sound sensible. |
|
You would move it to which module? |
|
config, already done in 4finance/micro-infra-spring#330 |
|
@marcingrzejszczak, I have used logback configuration from micro-infra-spring. Could you please look now? |
|
+1 |
dst
force-pushed
the
global-logback-config
branch
from
0b79d8b
to
583ebe7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.