Accessibility: Add a context menu to scenes under project panel for scene variables

[triptych]

Describe the bug

Please see this thread:

https://forum.gdevelop-app.com/t/creating-editing-scene-variables-feature-request/23191

The ask is that when you right click on a scene from the Project view you see an "Edit Scene Properties" option.

Here's the context menu:

this is to make it consistent - just like the context menu under the Objects panel:

The popup you see is just the same as if you right-clicked on a blank space in the scene:

Note the "Edit Scene Variables" button there.

This would allow for the discovery of editing scene variables just like object variables and global variables.

[PawBud]

I would like to work on this issue. Can you please guide me ?

[4ian]

Look at ProjectManager/index.js and ScenePropertiesDialog.
Looks where ScenePropertiesDialog is used and how/if you should move its usage.

[PawBud]

Understood @4ian. If I have any more issues then I will mention them here.

[PawBud]

@4ian can you please elaborate more. I have been trying it for some time and I just need some help.
Thanks :)

[4ian]

Have you located where ScenePropertiesDialog is used? Do you understand how it's opened?
If you used React before, do you have an idea about what to do? (if not, read some React tutorials before attempting anything ;)).

[PawBud]

Sure thanks a lot for helping @4ian

[PawBud]

I am aware of it @4ian it is just that somehow the index.js inside the MainFrame is showing errors as I try to resolve the errors in ProjectManager/Index.js

[PawBud]

any idea how to resolve it? I can share the precise errors that I am getting while trying to import the ScenePropertiesDialog if needed :).

[jimil749]

@4ian I was just tinkering with code and tried to implement the ScenePropertiesDialog like done in the SceneEditor/index.js and just found one minor issue. Inside of ProjectManager/index.js layout is not defined which is required by ScenePropertiesDialog.
I tried defining layout in props but of no use (Like done in SceneEditor/index.js). I tried to console log the layout props which yields 'undefined'. What I'm asking is that where is the 'layout' prop coming from and how to use it.

[PawBud]

well, technically it is defined as

layout: glayout.

[PawBud]

Moreover, how were you able to add it in the Properties menu @jimil749?

[jimil749]

well, technically it is defined as

layout: glayout.

I think its gdLayout, but even after doing that, it logs undefined on the console! The value into layout prop is undefined for some reason, that I'm not able to figure out currently

Moreover, how were you able to add it in the Properties menu @jimil749?

Look at `ProjectManger/index.js' and check where the other menu items are rendered! :)

[PawBud]

I definitely tried everything but I couldn't really make the Scene Properties Dialog run for some reason, although I will keep trying.

[PawBud]

@4ian I tried my best to solve this bug but unfortunately, I couldn't come up with a solution, although I am still willing to work on this bug since I want to contribute to this organization as much as I can so, Can you further guide me?

[4ian]

I have lots of other things to review and to do myself in a limited time every day so I would prefer a suggestion from you that I can then advise.
Here, you need to identify which React components must be opened, identify where to open them, what are the props they need and how to pass them. It's a good exercice that is fairly common in React: finding components and props, understanding what they do, seeing what you have in your state.

[PawBud]

Oh ok sure, yea .. is it ok if I post some screenshots explaining what I am trying to do & what its output is?

[4ian]

You can ask questions but do this in a PR so that I can see your code and ask questions as focused as possible :)

[PawBud]

Thanks a lot. I will post the screenshots in a new PR as you advised.

[nilaymaj]

@Somtozech Are you still working on this issue? I want to try this one.