Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example: City Builder #2638

Closed
D8H opened this issue May 11, 2021 · 11 comments
Closed

New example: City Builder #2638

D8H opened this issue May 11, 2021 · 11 comments

Comments

@D8H
Copy link
Collaborator

D8H commented May 11, 2021

Hi!

I'd like to submit a new example to be added to GDevelop.
Here is the link to

I confirm that any assets can be used freely by anybody, including for commercial usage.

It shows how to evaluate distance by roads to define rules for city builders.

This example use these extensions:

CityBuilder

@Midhil457
Copy link
Contributor

Hi, I reviewed the project and it was great and it works great.

I did found some problems,

  • There are some typos in the comments, I found some, but I think there are more
    Not sqares, neigborgs
    City2

  • There is an empty events with only an condition

City3

  • I also suggest adding some comments just explaining what some parts do in simple terms. It took me a lot of time,to understanding some parts 😅

:)

@D8H
Copy link
Collaborator Author

D8H commented May 12, 2021

Thanks for the review. I did the changes and did a pass on the typos.
Is it the part on the city evaluation that needs more explanations? (It's fresh in my mind so I may not see what could be hard to understand, but there is already long comments)

@Midhil457
Copy link
Contributor

Midhil457 commented May 12, 2021

I had a hard time figuring out how links work in the game/extension or how exactly links get to the neighbours that is being searched. When a condition checks for at most 12 links, it doesn't explain how that number is calculated/checked. And also the cost system too. You could say, I didn't understand how the whole link objects extension works 😅

:)

@D8H
Copy link
Collaborator Author

D8H commented May 12, 2021

I see, it's hard to understand graphs on the fly if you have never used it before. I will prepare a wiki page for this extensions with diagrams.
Edit : http://wiki.compilgames.net/doku.php/gdevelop5/all-features/extensions/linked-objects-tools

@Midhil457
Copy link
Contributor

Hi, I reviewed the project and I wasn't able to find any issues. I do have some suggestions

  • Using a single object with animations representing the Palette Items instead of multiple objects added to a group. But, I wasn't able to fully making it work while testing. So, I am not sure if it is possible

  • Also, as you have finished the wiki page, maybe you could include the link to the wiki so that people can learn how the linking system works. It could be helpful for someone who found it from the example list

:)

@D8H
Copy link
Collaborator Author

D8H commented May 14, 2021

* Using a single object with animations representing the Palette Items instead of multiple objects added to a group. But, I wasn't able to fully making it work while testing. So, I am not sure if it is possible

It would need more events and be less intuitive in the instances editor. I don't mind having a lot of objects if it makes the events easier to understand.

* Also, as you have finished the wiki page, maybe you could include the link to the wiki so that people can learn how the linking system works. It could be helpful for someone who found it from the example list

Yes, I did it yesterday silently.

@Midhil457
Copy link
Contributor

I wasn't able to find any comments that showed the wiki page's link. Did I miss it?

@D8H
Copy link
Collaborator Author

D8H commented May 15, 2021

I thought you were talking of this:
Help

It's true that's not the 1st thing that's used when reading a project. I added a note before the link action.

@Midhil457
Copy link
Contributor

Midhil457 commented May 16, 2021

That's great! But, I did find it hard to find the comment where you have added it. It would have been more visible if you added it in a comment with more visible colours (something like green) As this example is centred around linking. It would make sense to add it at the top, but the current place is still fine. Also, it is "double" not "

Other than that, I didn’t find any other issues

:)

@Midhil457
Copy link
Contributor

Hi, If you are still interested in adding it to the library, you may open a issue in the new repo

:)

@D8H
Copy link
Collaborator Author

D8H commented Aug 16, 2021

Right, thanks you, I opened this: GDevelopApp/GDevelop-examples#69

@D8H D8H closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants