Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked] Replace old variable icons with new brand icons #6041

Open
1 task done
LuniMoon opened this issue Dec 8, 2023 · 5 comments
Open
1 task done

[Blocked] Replace old variable icons with new brand icons #6041

LuniMoon opened this issue Dec 8, 2023 · 5 comments
Labels
😤Non optimal UI A bug/issue where the UI is usable but not optimal

Comments

@LuniMoon
Copy link
Collaborator

LuniMoon commented Dec 8, 2023

Note:
This change to update to today's icons has resistance and I do not have any user testing that brings any evidence on which is best (it's the kind of thing that requires A/B testing in app which is not possible today).
I've marked it as blocked for now.

Is there an existing issue for this?

Describe the bug

Brought to my attention after seeing this issue*.

Current icons are the old icons
image

Please replace them with today's Icons (refer to the Figma file "App Icons".
Screenshot 2023-12-08 at 13 58 16
You can press Ctrl+F to find the following images: "World", "Scene", "Box".

*Note: Changing text colour depending on the Variable type was suggested by the user. However I won't request it because I am not sure about the implications of assigning different colour to each Condition/Action variation on the engine.

Steps to reproduce

N/A

GDevelop platform

Desktop, Web, Mobile

GDevelop version

N/A

Platform info

OS (e.g. Windows, Linux, macOS, Android, iOS)

OS Version (e.g. Windows 10, macOS 10.15)

Browser(For Web) (e.g. Chrome, Firefox, Safari)

Device(For Mobile) (e.g. iPhone 12, Samsung Galaxy S21)

Additional context

No response

@LuniMoon LuniMoon added the 😤Non optimal UI A bug/issue where the UI is usable but not optimal label Dec 8, 2023
@ZachjuKamashi
Copy link

ZachjuKamashi commented Dec 9, 2023

This change may not be as good, as it's harder to differentiate between 3 different types of variables due to the new ones using only the same color. I'd suggest changing the color of the icons on the left and keeping the text on the right the same color

@BigChalkGames
Copy link

I agree with ZachjuKamashi. Whilst the icon changes will be a nice addition, I think colors are going to go a lot further when it comes to differentiating between the types.

Colors should be added to the below choices as well so you know at a glance what is a obj, scene or global.
image

@LuniMoon
Copy link
Collaborator Author

Thank you for sharing your opinion regarding the architecture colours.
However, I won't require any colour change yet because it requires more thinking: If each architecture notion has a colour they would have to apply to all elements that have "global, scene, object" notion and I'd like to make sure that they're accessible.
Also, an internal ticket has been created to explore work to simplify that list (which might cancel the need for differentiating the list with colours).

Core team, please refer to "AAU I see a more digestive list of Variables whenever I am working on my Events" on the "Product backlog" internal Notion.

I am keeping this ticket "icon change" only, and not request further changes.
Nevertheless, I'll keep an eye about colour conversations on the Feature request topic.

@ZachjuKamashi
Copy link

I am keeping this ticket "icon change" only, and not request further changes. Nevertheless, I'll keep an eye about colour conversations on the Feature request topic.

I view this icon change as a downgrade rather than upgrade. Currently the old ones are much more distinct due to them having different colors in their icons, like white within the scene icon and black within the object icon. This icon change removes those entirely and then they would all be the same color. This makes it more difficult to look at a glance on what variable you are dealing with.

I wouldn't push this change upon all users unless a solution to this issue is solved.

@LuniMoon LuniMoon changed the title Replace old variable icons with new brand icons [Blocked] Replace old variable icons with new brand icons Dec 19, 2023
@stale stale bot removed the wontfix label Dec 19, 2023
@LuniMoon
Copy link
Collaborator Author

I was thinking more about round, rectangle, prism shape for recognition by stripping the colours.

Note:
This change to update to today's icons has resistance and I do not have any user testing that brings any evidence on which is best (it's the kind of thing that requires A/B testing in app which is not possible today).
I've marked it as blocked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤Non optimal UI A bug/issue where the UI is usable but not optimal
Projects
None yet
Development

No branches or pull requests

3 participants