Separate the polygon editor from the sprite editor

[victorlevasseur]

Hi,
I've created that issue to discuss the way the polygon will be separated from the sprite editor.
For me, it can be made using a main class called, for example, PolygonEditor (maybe it's not a good idea of name as it's not a standalone editor, but an helper plugged to a wxPanel of wxScrolledWindow) or PolygonEditionHelper.
Then, the class will contain some functions that we will call from the Panel/ScrolledWindow using it : DrawEditor(wxDC&, wxPoint offset), OnLeftDownEvent(wxMouseEvent&) to be called from the Panel when the left mouse button is pressed.
Also, the class will contain the polygon "treeview" editor (to be added manually to its AuiManager or automatically from the ctor ?)

[victorlevasseur]

In fact, the class can't contain the polygon treeview editor as it contains some specific Sprite features such as copying the mask to the whole animation and so on...

[4ian]

A PolygonEditorHelper class would be still nice I think :) It should provide as you said so feature so that it can be connected to a wxPanel (the poloygon editor helper should be agnostic regarding what is displayed inside the panel: it should just draw the polygon and the anchors, and handle events using its OnLeftDownEvent method).

For the treeview, it may be excluded from this refactoring for now.. Maybe it could be included just after, and provide a separate method to customize the toolbar (so that the sprite editor can add its own buttons in the toolbar :) )

[victorlevasseur]

Currently working on it on my fork's polygon-edition-helper branch.
I've made the choice to pass almost all the required stuff (vector of polygons, offset, maximum polygon point position) in each functions (OnPaint, OnMouseLeftDown, OnMouseMove, ...) to make it work easily with the sprite editor (as the mask is got again and again in each editor's functions).
So the PolygonEditionHelper is restricted only to the drawing and to the point drag&drop without owning the polygons and even a pointer to the polygons.
I plan to do almost a similar thing for the Tree view but it'll come afterwards.

[4ian]

Excellent choice, I think it's the best choice to make for a helper class
(having methods that can be simply used by a call with all the necessary
argument). It will be easy to plug this helper class into the already
existing sprite editor !

Keep up the good work, let me know if you need help on a particular point :)