Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Polygon2d directory and add it to gd namespace #22

Closed
victorlevasseur opened this issue Sep 16, 2014 · 3 comments
Closed

Change Polygon2d directory and add it to gd namespace #22

victorlevasseur opened this issue Sep 16, 2014 · 3 comments
Assignees

Comments

@victorlevasseur
Copy link
Contributor

I think the Polygon2d class is not at the good place in GDCore.
Maybe we can move it from GDCore/BuiltinExtensions/SpriteExtension to another directory. Which one ?
Then, we can move it into the gd namespace (even if it's used by GDCpp's games ?).

@victorlevasseur victorlevasseur changed the title Move Polygon2d to GDCore/Tools or GDCore/PlatformDefinition Chang Polygon2d directory and add it to gd namespace Sep 16, 2014
@victorlevasseur victorlevasseur changed the title Chang Polygon2d directory and add it to gd namespace Change Polygon2d directory and add it to gd namespace Sep 16, 2014
@4ian 4ian self-assigned this Sep 17, 2014
@4ian
Copy link
Owner

4ian commented Sep 17, 2014

For now, most files uses Polygon by refering to GDCpp/Polygon.h (which is nice, but as the class is named Polygon2d, it should be renamed to GDCpp/Polygon2d.h).
No classes in GDCore/PlatformDefinition are using Polygon so I'm not sure it should not be in this directory..

@victorlevasseur
Copy link
Contributor Author

You've forgotten to change the include in the GDCpp/Polygon2d.cpp file. ;)
(Don't do anything, I've fixed it in a bugfix pull-request for the tilemap object)

@4ian
Copy link
Owner

4ian commented Sep 19, 2014

Oops, good catch ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants